Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not connecting to Embedded Node on startup #116

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Not connecting to Embedded Node on startup #116

merged 2 commits into from
Apr 12, 2024

Conversation

KingGorrin
Copy link
Collaborator

This PR fixes issue #115

PR #63 delayed starting the Embedded Node and made a slight change to the initWebSocketClient function. The Embedded Node is started correctly, but when initializing the connection the kCurrentNode needs to be translated to kLocalhostDefaultNodeUrl in case the Embedded Node is selected.

Previously the function always used kLocalhostDefaultNodeUrl as a fallback. This was removed because of the delayed startup.

@KingGorrin KingGorrin self-assigned this Apr 9, 2024
@KingGorrin KingGorrin added the bug Something isn't working label Apr 9, 2024
@KingGorrin KingGorrin merged commit 9ac2b96 into master Apr 12, 2024
4 checks passed
@KingGorrin KingGorrin deleted the hotfix-0.2.1 branch April 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants