[dep] Use Rand type instead of deprecated rand.Seed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are still passing |
georgezgeorgez
requested review from
0x3639,
MoonBaZZe,
interstellartraveler77 and
sumamu
Determinstic random generator should not be set by rand.Seed https://pkg.go.dev/math/rand#Seed golang/go#56319
georgezgeorgez
force-pushed
the
dep/rand-seed
branch
from
0cdbc32
to
cade01b
Compare
georgezgeorgez
changed the title
MoonBaZZe
approved these changes
Sep 29, 2023
|
I will approve after @sumamu reviews. |
|
@sumamu I think you missed this last PR. Once you approve it so will I. thx! |
sumamu
approved these changes
Oct 14, 2023
I looked into it a bit, then realized those were the unit tests so we're good to go. |
0x3639
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determinstic random generator should not be set by rand.Seed
https://pkg.go.dev/math/rand#Seed
golang/go#56319