Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc] Fix AccountBlock UnmarshalJSON #29

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[rpc] Fix AccountBlock UnmarshalJSON #29

merged 1 commit into from
Oct 10, 2023

Conversation

georgezgeorgez
Copy link
Collaborator

Following up from #27 (comment)

@georgezgeorgez
Copy link
Collaborator Author

I have tested this change
Took a transaction that sent ZNN and had been received
Current behavior unmarshals the tokenInfo and paired block as nil
After the change, it has the right values

@sol-znn
Copy link
Contributor

sol-znn commented Sep 1, 2023

@sumamu @MoonBaZZe Can you please check this out?

@georgezgeorgez georgezgeorgez added the bug Something isn't working label Sep 9, 2023
MoonBaZZe
MoonBaZZe reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@MoonBaZZe MoonBaZZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@MoonBaZZe MoonBaZZe self-requested a review September 28, 2023 13:32
@georgezgeorgez georgezgeorgez merged commit 3613473 into master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x3639 0x3639 0x3639 approved these changes

@MoonBaZZe MoonBaZZe MoonBaZZe approved these changes

@sumamu sumamu sumamu approved these changes

@interstellartraveler77 interstellartraveler77 Awaiting requested review from interstellartraveler77

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@georgezgeorgez @sol-znn @0x3639 @MoonBaZZe @sumamu