Fix libznn for Windows #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alienc0der
approved these changes
Aug 2, 2023
alienc0der
approved these changes
Aug 2, 2023
sumamu
approved these changes
Aug 2, 2023
|
I've reviewed and also requested reviews from other collaborators. Need 2 more reviews. |
|
@0x3639 @georgezgeorgez @sumoshi21 @MoonBaZZe Since we will probably be releasing a new libznn.dll with the fork fix, it would be nice to include this change in our build process. |
0x3639
approved these changes
Aug 10, 2023
alienc0der
approved these changes
Aug 11, 2023
sumamu
requested review from
georgezgeorgez
and removed request for
georgezgeorgez
georgezgeorgez
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been affecting some Windows users for the last few months.
The absence of any stack trace related to the sudden crash hindered the investigation, but we discovered that the output is stable if we compile it with xgo and go <1.20.0
More details can be found here: hypercore-one#4
User reports: https://forum.zenon.org/t/syrius-v0-0-6-crashes-with-embedded-node/1376