Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quill to v1.0.3 (stable) #106

Merged
merged 51 commits into from
Sep 20, 2016
Merged

Update Quill to v1.0.3 (stable) #106

merged 51 commits into from
Sep 20, 2016

Conversation

alexkrolick
Copy link
Collaborator

@alexkrolick alexkrolick commented Jul 25, 2016

Updates

Upgrade Quill dependency to 1.0.0 (#113 )

Breaking changes

  • Some Quill APIs have changed in a backwards-incompatible manner, including getHTML, addFormat, and the Toolbar configuration being moved to a module. Please see the official upgrade guide and the new README for more information.

Notes

  • Incorporates @clemmy's PR for beta-4, but tracks released Quill versions instead of a forked-and-compiled version. (Note that Quill only distributes dist/ files for released versions)
  • Adds instructions to use new Toolbar module API to the README
  • Bypasses use of deprecated addFormat API in favor of passing directly to Quill in config
    • For backward compatibility with Quill 0.20, this should perhaps be a configurable option. Depends on whether a breaking change the wrapper is OK since it is providing the Quill dependency.

clemmy and others added 30 commits May 12, 2016 15:19
Upgrade to Quill version 1.0.0-Beta.4
aaihZ1O0 Prevent extra newlines from being added on creation
@alexkrolick alexkrolick changed the title Update Quill to v1.0.0-beta9 Update Quill to v1.0.0-beta-10 Aug 3, 2016
- Semver: might be a breaking API change, so call it 2.0 and mark as beta
@stevenarnold
Copy link

Do I need special resources of some kind to use this, like fonts or something? I tried using this branch and got some very weird visual effects. Here's a screenshot on Chrome 51 (http://screencast.com/t/tXTJbvdomo) and Firefox 47 (http://screencast.com/t/PlbGkIYFgJpu). I assume it looks and feels good for you, right?

@alexkrolick
Copy link
Collaborator Author

You need to include the CSS in your app - how that gets pulled in depends on how your project manages assets. See node_modules/quill/dist/quill.snow.css

@alexkrolick alexkrolick changed the title Update Quill to v1.0.0-beta-10 Update Quill to v1.0.0-beta-11 Aug 4, 2016
@stevenarnold
Copy link

Thanks Alex, that was it. I thought I had that under control, but changing repos broke it.

@shapiromatron
Copy link

@alexkrolick I could use this as well; anything I can do to help?

@alexkrolick
Copy link
Collaborator Author

The fork that this PR is based on is working pretty well for me: https://github.com/alexkrolick/react-quill

The original refactoring to work with Quill v1 was done on @clemmy's branch.

The main question here is whether to make the react-quill configuration API backwards-compatible with the version using the pre-release Quill.

@stevenarnold
Copy link

Incidentally, this branch is working beautifully for me in dev.

@alexkrolick alexkrolick changed the title Update Quill to v1.0.0-beta-11 Update Quill to v1.0.0-rc.0 Aug 18, 2016
@alexkrolick
Copy link
Collaborator Author

Quill v1.0.0 is around the corner - would be great to hash out the upgrade path for users still on the pre-release version. Would love any feedback from anyone actively using this fork.

@igolden
Copy link

igolden commented Aug 22, 2016

Quill v1.0.0 is here! Will download and checkout this fork today. I need to access the new header option in our app.

@alexkrolick
Copy link
Collaborator Author

alexkrolick commented Aug 22, 2016

@igolden v1.0.0 is only at the release candidate stage - there's one more round of testing before it goes out. That said, please check out the fork and report any issues you have upgrading or using the next version of either Quill or this wrapper.

EDIT: Also check out the changes in the README about how to work with the new toolbar format.

@alexkrolick
Copy link
Collaborator Author

Unless anyone needs it I am going to not update the fork for Quill rc.1 because it seems like there may be an issue with the bundling of the packaged min.js: slab/quill#881

- bump version to 2.0.0
@alexkrolick alexkrolick changed the title Update Quill to v1.0.0-rc.0 Update Quill to v1.0.0 (stable) Sep 6, 2016
@alexkrolick
Copy link
Collaborator Author

Quill 1.0.0 has been released, so I've updated the dependency and bumped the major version of the package at my fork.

@alexkrolick alexkrolick changed the title Update Quill to v1.0.0 (stable) Update Quill to v1.0.3 (stable) Sep 13, 2016
@zenoamaro zenoamaro merged commit f0b9215 into zenoamaro:master Sep 20, 2016
@zenoamaro
Copy link
Owner

Thanks for this incredible contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants