Placeholder is not updating

[dbabaioff]

If I try to re-render my component with a different placeholder - the placeholder is not changing.

Looking into: react-quill/lib/component.js
The placeholder is not on dirtyProps list

See example:
https://codepen.io/dbabaioff/pen/pLJyLq

React-Quill version
[*] 1.2.0

[alexkrolick]

Care to PR in a fix?

[RafikiTiki]

If you put placeholder in dirtyProps Quill will reinstantiate on every placeholder change which probably is not very optimal. There isn't any API in Quill itself to change placeholder and as stated in this comment from Quill contributor owner, we should use dataset to change placeholder. Way to do it:

1. You need to set up refs as described here -> example
2. After you have refs set up use this code in any place you want to update placeholder (react lifecycle or whatever):this.quillRef.root.dataset.placeholder = 'Placeholder text'

[alexkrolick]

Ok, let's defer to the Quill recommendation for handling placeholder. I'll add a note to the README.

[alkismavridis]

I know this issue is closed since a long time, but I would expect that this should be an internal responsibility of react-quill instead of forwarding this responsibility to the users. You could make the placeholder prop really work by doing something like that on your side:

useEffect(() => {
    ref.current.getEditor().root.dataset.placeholder = props.placeholder || "";
  }, [ref, props.placeholder]);

With the current implementation, your users are responsible for doing this themselves, and the nature of the placeholder prop is confusing. Renaming it to initialPlaceholder (or actually fixing it) would be much better IMO.