Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tabIndex prop to allow for sequential tabbing in forms #232

Closed
haxxxton opened this issue Jul 12, 2017 · 2 comments
Closed

Provide tabIndex prop to allow for sequential tabbing in forms #232

haxxxton opened this issue Jul 12, 2017 · 2 comments

Comments

@haxxxton
Copy link

haxxxton commented Jul 12, 2017

When quill is part of a form where previous/next inputs have tabindex > 0, sequential tabbing is lost, as elements of quill do not allow for tabIndex to be specified. It would be great if all elements generated by quill had their tabIndex explicitly set to a defined prop that defaulted to 0.

Quill version

  • 1.0.0
@zenoamaro
Copy link
Owner

I think tabIndex support for the built-in editing area is a sensible request. I'm all for this being in the next release.

However, I can't see how the same could be done for the toolbar, without either providing a custom toolbar, or monkey patching the elements (which I won't do). I suggest pushing your proposal upstream to Quill itself.

In the meantime, you can accomplish both, in a slightly more verbose way, this by providing a custom editing area and a custom toolbar.

zenoamaro added a commit that referenced this issue Aug 4, 2017
Added tabIndex prop for built-in editing area. Closes #232
@herrherrmann
Copy link
Contributor

herrherrmann commented Feb 28, 2018

The new tabIndex prop unfortunately does not seem to work for me. The tabindex property doesn't seem to be applied to the div with the ql-editor class (which seems to still get focus through tabbing because it has contenteditable set to true).

ql tabindex

I could provide a little PR for that although I guess that should be handled by Quill itself instead.

herrherrmann added a commit to herrherrmann/react-quill that referenced this issue Feb 28, 2018
Quill unfortunately doesn't provide an API to set the editor's
tabindex, so we have to override it directly on its dom node.
Also see zenoamaro#232 (comment)
alexkrolick pushed a commit that referenced this issue Jun 19, 2018
* Propagate tabindex prop to editor's scroll container

Quill unfortunately doesn't provide an API to set the editor's
tabindex, so we have to override it directly on its dom node.
Also see #232 (comment)

* Update component.js
Coventh added a commit to Coventh/react-quill that referenced this issue Nov 14, 2024
* Propagate tabindex prop to editor's scroll container

Quill unfortunately doesn't provide an API to set the editor's
tabindex, so we have to override it directly on its dom node.
Also see zenoamaro/react-quill#232 (comment)

* Update component.js
mikelhowell27 added a commit to mikelhowell27/react-quill that referenced this issue Dec 22, 2024
* Propagate tabindex prop to editor's scroll container

Quill unfortunately doesn't provide an API to set the editor's
tabindex, so we have to override it directly on its dom node.
Also see zenoamaro/react-quill#232 (comment)

* Update component.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants