Don't initialize client during flavor sync #3168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
This PR fixes another loop that happens during the flavor sync:
GlobalConfig.zen_store
gets accessed, which starts the flavor syncFlavor.to_model(...)
gets called which initializes theClient
.zen
repository exists, the client tries to sanitize it's config, which in turn callsGlobalConfig.zen_store
-> This second access of
GlobalConfig.zen_store
now tries to create the default stack and fails because the flavors are not in the database yetPre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes