-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper method to quickly create run template from pipeline #3155
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried to test this, I ran into some stuff that I was not expecting:
- I forgot to switch to a remote stack and I got this error:
ValueError: Unable to create run template as there is no associated build.
While I understand where this is coming from, the new users might be a bit confused due to the message here. Maybe we can add something like: Make sure you have an active remote stack.
.
- When I tried to use the same name for the template, I got the error:
EntityExistsError: Unable to create run template in workspace 'default': A run template with this name already exists.
I think this is more of a general issue, but I would remove the mention of workspaces here and add the name of the entity to the message.
- I also realized one more thing about the run templates. I had some
DockerSettings
defined for my pipeline and before we could create the template, I had to create and push the build. When I look at the editor on the dashboard, I see theDockerSettings
are not there, as the template is already tied to a build. I understand this is what's needed atm, but it might be nice to adjust things like builds or stacks of the templates in the future.
The issues that I mentioned are minor issues, feel free to merge if you want.
docs/book/how-to/pipeline-development/trigger-pipelines/use-templates-python.md
Outdated
Show resolved
Hide resolved
…mplates-python.md Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
|
…-io/zenml into feature/run-template-helper-method
Describe changes
This PR adds a small helper method to create a run template for a pipeline without running it first:
This can be useful in CI scenarios, where only a template should be created for later runs instead of running it immediately.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes