-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Restructure how-to section to make it more readable #3147
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You moved all these but did not change the links within the content! :-D
.gitbook.yaml
Outdated
how-to/use-the-model-control-plane/README.md: how-to/model-management-metrics/model-control-plane/README.md | ||
how-to/use-the-model-control-plane/register-a-model.md: how-to/model-management-metrics/model-control-plane/register-a-model.md | ||
how-to/use-the-model-control-plane/delete-a-model.md: how-to/model-management-metrics/model-control-plane/delete-a-model.md | ||
how-to/use-the-model-control-plane/associate-a-pipeline-with-a-model.md: how-to/model-management-metrics/model-control-plane/associate-a-pipeline-with-a-model.md | ||
how-to/use-the-model-control-plane/connecting-artifacts-via-a-model.md: how-to/model-management-metrics/model-control-plane/connecting-artifacts-via-a-model.md | ||
how-to/use-the-model-control-plane/model-versions.md: how-to/model-management-metrics/model-control-plane/model-versions.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left side should not end in .md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixing it!
@htahir1 we don't need to change the links in all files, that's what the redirects help with, correct? Just verified that links in pages that point to the moved docs still work. For example, check out the |
@wjayesh i know but isnt it weird to have intentionally broken links? can we just change these to point to the right paths please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small thing but totherwise looks good to go
.gitbook.yaml
Outdated
how-to/build-pipelines/name-your-pipeline-and-runs: how-to/pipeline-development/build-pipelines/name-your-pipeline-runs.md | ||
|
||
# Project Setup redirects | ||
how-to/setting-up-a-project-repository/README: how-to/project-setup-and-management/setting-up-a-project-repository/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.zenml.io/how-to/setting-up-a-project-repository/README is not a real link. These README ones resolve to https://docs.zenml.io/how-to/setting-up-a-project-repository/ without the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update for all the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, i see. let me update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done and tested for all README files
@@ -67,7 +67,7 @@ loaded_artifact = artifact.load() | |||
While ZenML strives for backward compatibility, be prepared for occasional breaking changes (e.g., [the Pydantic 2 upgrade](https://github.com/zenml-io/zenml/releases/tag/0.60.0)). | |||
|
|||
- **Changelog Review**: Always review the [changelog from new releases](https://github.com/zenml-io/zenml/releases) for new syntax, instructions, or breaking changes. | |||
- **Migration Scripts**: Use provided [migration scripts](../../how-to/manage-the-zenml-server/migration-guide/migration-guide.md) when available to handle database schema changes. | |||
- **Migration Scripts**: Use provided [migration scripts](migration-guide/migration-guide.md) when available to handle database schema changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the migration guide is in the same directory and resolves to the right file
Describe changes
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes