Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittest to cover gitlab CR regex. #3102

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

4gt-104
Copy link
Contributor

@4gt-104 4gt-104 commented Oct 18, 2024

Add different test cases to cover regex
defined in 'GitLabCodeRepository'
'check_remote_url' method.

Related to #3076

Describe changes

I have added unittest for regex updated in my previous PR.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Improving code coverage.

Add different test cases to cover regex
defined in 'GitLabCodeRepository'
'check_remote_url' method.

Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com>
@schustmi schustmi merged commit 30f1765 into zenml-io:develop Oct 21, 2024
48 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants