Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not tag model via Model class on creation #3098

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 18, 2024

Describe changes

I removed the tagging of the Model entity if it gets created implicitly via the Model class. (e.g. set in @pipeline).

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 18, 2024
@htahir1 htahir1 requested a review from schustmi October 18, 2024 09:14
@htahir1
Copy link
Contributor

htahir1 commented Oct 18, 2024

@schustmi is this the same behavior with pipeline and pipeline runs?

Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭 Thanks for this

@schustmi
Copy link
Contributor

There is no behaviour for pipelines and pipeline runs yet

@avishniakov avishniakov merged commit b5c6eac into develop Oct 18, 2024
54 of 55 checks passed
@avishniakov avishniakov deleted the feature/PRD-683-do-not-tag-model-via-Model-class branch October 18, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants