-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on common stacks best practices #3092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can do this part of the restructuring but I thought it might make sense to feature this a bit more prominently ? However in general this looks good I’ll take a look tomorrow again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general, it needs more links (i have added some already) and some fixes to the commands. good work thinking about the headings, not much more i would add to that
Co-authored-by: Jayesh Sharma <wjayesh@outlook.com>
Co-authored-by: Jayesh Sharma <wjayesh@outlook.com>
Co-authored-by: Jayesh Sharma <wjayesh@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, lets maybe make it more prominent in the restructuring
Focused on the AWS and GCP sections since for the rest we have a lot of other best practices in the component docs (which those guides already point back to).
Also not quite sure how much of this is redundant.