Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on common stacks best practices #3092

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

strickvl
Copy link
Contributor

Focused on the AWS and GCP sections since for the rest we have a lot of other best practices in the component docs (which those guides already point back to).

Also not quite sure how much of this is redundant.

@strickvl strickvl added documentation Improvements or additions to documentation internal To filter out internal PRs and issues labels Oct 16, 2024
@strickvl strickvl requested review from htahir1 and wjayesh October 16, 2024 15:03
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do this part of the restructuring but I thought it might make sense to feature this a bit more prominently ? However in general this looks good I’ll take a look tomorrow again

Copy link
Contributor

@wjayesh wjayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, it needs more links (i have added some already) and some fixes to the commands. good work thinking about the headings, not much more i would add to that

docs/book/how-to/popular-integrations/aws-guide.md Outdated Show resolved Hide resolved
docs/book/how-to/popular-integrations/aws-guide.md Outdated Show resolved Hide resolved
docs/book/how-to/popular-integrations/aws-guide.md Outdated Show resolved Hide resolved
docs/book/how-to/popular-integrations/aws-guide.md Outdated Show resolved Hide resolved
docs/book/how-to/popular-integrations/gcp-guide.md Outdated Show resolved Hide resolved
docs/book/how-to/popular-integrations/gcp-guide.md Outdated Show resolved Hide resolved
@strickvl strickvl requested review from wjayesh and htahir1 October 17, 2024 08:58
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, lets maybe make it more prominent in the restructuring

@strickvl strickvl merged commit 4410544 into develop Oct 17, 2024
9 checks passed
@strickvl strickvl deleted the doc/common-stacks-best-practices branch October 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants