Sagemaker add pipeline tags #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
|
@bcdurak i have not tested this, so if u can test it id be grateful |
|
LLM Finetuning template updates in |
|
E2E template updates in |
schustmi
reviewed
Oct 14, 2024
src/zenml/integrations/aws/orchestrators/sagemaker_orchestrator.py
Outdated
Show resolved
Hide resolved
|
Classification template updates in |
schustmi
requested changes
Oct 14, 2024
| @@ -332,6 +332,7 @@ def prepare_or_run_pipeline( | |||
| else None | |||
| ), | |||
| ) | |||
| pipeline_tags = step_settings.pipeline_tags | |||
There was a problem hiding this comment.
Ah another thing: This is taking the pipeline tags from the settings specified for a specific step? I'm guessing this is in a for-loop and will just use the settings of the latest step.
Instead, I think we should use the tags defined on the pipeline settings (self.get_settings(deployment))
There was a problem hiding this comment.
pfft right again. Im rusty AF. Sorry
htahir1
commented
Oct 18, 2024
htahir1
commented
Oct 18, 2024
htahir1
commented
Oct 18, 2024
htahir1
commented
Oct 18, 2024
bcdurak
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I added tags to sagemaker pipelines
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes