Added some adjustments for colab #2966
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
internal
There was a problem hiding this comment.
One thing that really sort of sucks in colab right now as well on top of this change is that there is a pip install zenml command which restarts the environment and then a git clone command and pip install -r requirements.txt command that again restarts the env and then there is a third block that restarts the notebook explcitiy! maybe we can put it all in one block?
Yeah was thinkgin about this as well, just wondering, if we should then already ask for thetype of cloud at the very top |
|
@AlexejPenner good idea! |
AlexejPenner
changed the title
I will do one final sweep over all 12 supported permutations before clicking merge so far this is promissing |
|
Tested the following scenarios
|
|
@htahir1 what do you think? merge to main and rebase of develop on top of this? |
|
@AlexejPenner sure why not |
…ml-io/zenml into feature/small-quickstart-adjustments
…ml-io/zenml into feature/small-quickstart-adjustments
|
LLM Finetuning template updates in |
|
Classification template updates in |
|
E2E template updates in |
|
NLP template updates in |
…ml-io/zenml into feature/small-quickstart-adjustments
* Added some adjustments for colb * Rehauled so notebook execution only requires one Kernel restart * Reformatted * Reduced requirements.txt, made run.py clearer * Caught hardcoded stack name, commented configs * Formatted * Added Model to quickstart * Using AWS private ecr now * Working with aws docker-free * Reformatted * Training step needs more memory in aws * Simplified running from CLI * Formated * Applied reviews * applied PR comments * Applied more reviews * Make aws actually work * Linted * Auto-update of LLM Finetuning template * Auto-update of Starter template * Auto-update of E2E template * Auto-update of NLP template * Switch AWS quickstart container image to the AWS production account * Push quickstart AWS image to ECR during the release workflow * Fix linter issues * Fix newly introduced wandb linter error --------- Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Stefan Nica <stefan@zenml.io>
Describe changes
Colab needs to restart after pip installation of requirements.
Also changed:
python run.py --model_type=t5-small --orchestration_environment awstopython run.py --model_type=t5-small --config_path configs/training_aws.yamlto make it more clear that this does no stack switching, instead its simply about the config file. But the best thing is, you don't need to specify the config file at all.Added docker settings to the default config file to allow stack switching with 0 change.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes