-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message sagemaker, better documentation server env vars #2885
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
"Timed out while waiting for pipeline execution to finish. For long-running " | ||
"pipelines we recommend configuring your orchestrator for asynchronous execution. " | ||
"The following command does this for you: \n" | ||
"`zenml orchestrator update <ORCHESTRATOR-NAME> --synchronous=False`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe self.name
to have it concrete?
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
…ml into feature/misc-smaller-change
docs/book/getting-started/deploying-zenml/deploy-with-docker.md
Outdated
Show resolved
Hide resolved
Quickstart template updates in |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ml into feature/misc-smaller-change
Describe changes
When starting long running pipelines on sagemaker with the orchestrator configured to be synchronous, the error message was a bit cryptic. The new error message should instruct the user in what to do to avoid hitting it again.
The JWT_SECRET_KEY was not accessible anywhere in the docs.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes