-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename log_model_version_metadata to log_model_metadata #2215
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughZenML has introduced a new function Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🦭
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- src/zenml/init.py (2 hunks)
- src/zenml/model/utils.py (1 hunks)
- tests/integration/functional/model/test_model_version.py (3 hunks)
Files skipped from review due to trivial changes (1)
- tests/integration/functional/model/test_model_version.py
Additional comments: 6
src/zenml/__init__.py (2)
45-45: The import statement for
log_model_metadata
has been added correctly.61-61: The addition of
log_model_metadata
to the__all__
list is correct, making it part of the public API.src/zenml/model/utils.py (4)
141-147: The deprecation warning for
log_model_version_metadata
is clear and the function now proxies tolog_model_metadata
.150-154: The signature of
log_model_metadata
correctly makes themodel_version
parameter optional, aligning with the PR objectives.154-158: The error handling in
log_model_metadata
to raise aValueError
when required parameters are missing is implemented correctly.125-161: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [158-174]
The logic to use the model version from the step context if available in
log_model_metadata
is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests passing. I also added it to our deprecations list for tracking.
Describe changes
I Renamed log_model_version_metadata to log_model_metadata to make it more consistent with log_artifact_metadata + i made it part of the public api so you can import it like;
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit
New Features
log_model_metadata
function for enhanced model metadata logging.Deprecated
log_model_version_metadata
in favor of the new logging function.Enhancements
Error Handling
Tests