Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PyPi release depend on DB migration tests passing #2088

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Make PyPi release depend on DB migration tests passing #2088

merged 1 commit into from
Nov 29, 2023

Conversation

strickvl
Copy link
Contributor

Release should not happen if DB migration tests fail.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working enhancement New feature or request internal To filter out internal PRs and issues labels Nov 28, 2023
bcdurak
bcdurak approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@strickvl strickvl merged commit 3439b18 into develop Nov 29, 2023
32 checks passed
@strickvl strickvl deleted the misc/release-depends-on-db-testing-passing branch November 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdurak bcdurak bcdurak approved these changes

@fa9r fa9r fa9r approved these changes

@safoinme safoinme Awaiting requested review from safoinme

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strickvl @fa9r @bcdurak