Make zenml up prefill username when launching dashboard
#2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
enhancement
schustmi
reviewed
Nov 6, 2023
src/zenml/api.py
Outdated
| url = f"{url}:{port}" if port else url | ||
| if prefill_username: | ||
| url = ( | ||
| f"{url}:{port}/login?username={DEFAULT_USERNAME}" if port else url |
There was a problem hiding this comment.
If someone were to configure their local server with external authentication support, will this mess with it in any way @stefannica?
There was a problem hiding this comment.
A local server with external authentication support is not supported and not even technically possible, not even for development purposes.
fa9r
reviewed
Nov 6, 2023
fa9r
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
LGTM from my side but let's wait for clarification from @stefannica regarding @schustmi's comment
stefannica
approved these changes
Nov 10, 2023
stefannica
deleted the
feature/OSS-2587-zenml-up-with-prefilled-username
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zenml uplaunches the dashboard (unless you have a specific env variable set) without any details prefilled for the login screen. This PR addresses that and launches with thedefaultpreset in the dashboard.Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes