Skip to content

Commit

Permalink
Misc cleanup after release (#2861)
Browse files Browse the repository at this point in the history
* Misc cleanup after release

* Fix mypy
  • Loading branch information
schustmi authored Jul 22, 2024
1 parent 4151a92 commit 68498a9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 1 addition & 3 deletions src/zenml/entrypoints/entrypoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

import argparse
import logging
import os
import sys

from zenml import constants
Expand Down Expand Up @@ -45,8 +44,7 @@ def main() -> None:
parser = argparse.ArgumentParser()
parser.add_argument(f"--{ENTRYPOINT_CONFIG_SOURCE_OPTION}", required=True)
args, remaining_args = parser.parse_known_args()
if os.environ.get(constants.ENV_ZENML_CUSTOM_SOURCE_ROOT):
source_utils.set_custom_source_root(source_root=os.getcwd())

entrypoint_config_class = source_utils.load_and_validate_class(
args.entrypoint_config_source,
expected_class=BaseEntrypointConfiguration,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def _validate_remote_components(
stack: "Stack",
) -> Tuple[bool, str]:
for component in stack.components.values():
continue # TODO: Remove this line
if not component.config.is_local:
continue

Expand Down
5 changes: 4 additions & 1 deletion src/zenml/utils/source_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
Source,
SourceType,
)
from zenml.constants import ENV_ZENML_CUSTOM_SOURCE_ROOT
from zenml.environment import Environment
from zenml.logger import get_logger

Expand All @@ -57,7 +58,9 @@
type=SourceType.BUILTIN,
)

_CUSTOM_SOURCE_ROOT: Optional[str] = None
_CUSTOM_SOURCE_ROOT: Optional[str] = os.getenv(
ENV_ZENML_CUSTOM_SOURCE_ROOT, None
)


def load(source: Union[Source, str]) -> Any:
Expand Down
4 changes: 2 additions & 2 deletions src/zenml/zen_server/routers/steps_endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def create_run_step(
pipeline_run = zen_store().get_run(step.pipeline_run_id)
verify_permission_for_model(pipeline_run, action=Action.UPDATE)

step = zen_store().create_run_step(step_run=step)
return dehydrate_response_model(step)
step_response = zen_store().create_run_step(step_run=step)
return dehydrate_response_model(step_response)


@router.get(
Expand Down

0 comments on commit 68498a9

Please sign in to comment.