Fix issue buger#188

zengjinzheng · Mar 17, 2020 · 1dc7c82 · 1dc7c82
1 parent 1a29609
commit 1dc7c82
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/parser.go b/parser.go
@@ -98,9 +98,16 @@ func findKeyStart(data []byte, key string) (int, error) {
 			}
 
 		case '[':
-			i = blockEnd(data[i:], data[i], ']') + i
+			ret = blockEnd(data[i:], data[i], ']')
+			if ret != -1 {
+				i = i + ret
+			}
+
 		case '{':
-			i = blockEnd(data[i:], data[i], '}') + i
+			ret = blockEnd(data[i:], data[i], '}')
+			if ret != -1 {
+				ret = i + ret
+			}	
 		}
 		i++
 	}

diff --git a/parser_test.go b/parser_test.go
@@ -185,6 +185,18 @@ var deleteTests = []DeleteTest{
 		path: []string{"b"},
 		data: `{"a": "1" , "c": 3}`,
 	},
+	{
+		desc: "Issue #188: infinite loop in Delete",
+		json: `"^_ï¿½^C^A^@["`,
+		path: []string{""},
+		data: `"^_ï¿½^C^A^@["`,
+	},
+	{
+		desc: "Issue #188: infinite loop in Delete",
+		json: `"^_ï¿½^C^A^@{"`,
+		path: []string{""},
+		data: `"^_ï¿½^C^A^@{"`,
+	}
 }
 
 var setTests = []SetTest{