This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Complete zend-servicemanager v2+v3 compatibility #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2016
Makes the following changes to ensure v2 + v3 compatibility: - Use the same signature as the v2 abstract plugin manager. - In the constructor, call `addInitializer()` instead of adding initializers to the configuration array; guarantees compatibility. - Add `$shareByDefault` property as alias for `$sharedByDefault`.
…mework#56 - Each of which have been merged to this patch.
- zend-filter 2.6 - zend-stdlib 2.7/3.0 - zend-math 2.6 - zend-config 2.6
- Updates all dependencies to stable versions; if the dependency has forwards-compat changes for v3 components, pins to those. - Selectively skip zend-db, zend-session tests when testing against servicemanager v3.
ValidatorPluginManager: - Removed all barcode adapters from aliases and factories; these are not actual validators, but consumed by the barcode validator. - Used `$plugin` terminology over `$instance` for validation. - Modified `validatePlugin()` to throw v2 exception. - Added factory entries using normalized names to ensure BC with v2. - Used `$container` verbiage over `$locator` verbiage. - Updated `injectTranslator` to check if being used in a v2 context; if so, it pulls the translator from the parent container. - Simplified tests for translator injection verification using Prophecy. - Updated tests for expected exceptions to test for either v2 or v3 exceptions. - Added compatibility tests. StaticValidator: - Configure the "share by default" flag based on version of zend-servicemanager.
weierophinney
force-pushed
the
feature/50
branch
from
9a41568
to
6efb07b
Compare
weierophinney
added a commit
that referenced
this pull request
Feb 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on the commits from #50, and adds the following changes to the
ValidatorPluginManagerto guarantee v2 + v3 compatibility:addInitializer()instead of adding initializers to the configuration array; guarantees compatibility.$shareByDefaultproperty as alias for$sharedByDefault.and various and other sundry updates. Currently tested against both v2 and v3 of the servicemanager, on all platforms.
Currently, several tests fail due to pending zend-i18n updates. Additionally, since several dependencies also require zend-servicemanager and have not yet been updated to work with both v2 and v3, v2 tests cannot run.