Added PHPUnit 8 support #76
Conversation
Added traits with methods which can be used in tests and in PHPUnit 8 have RTH defined. We load proper trait depends on used PHPUnit version. In our classes to keep compatibility we use method with "Compat" suffix. Fot the end user nothing is changed as long as the user decide to support one PHPUnit version (any <7 or 8+). Depends on the version user can define setUp/tearDown method compatible with the used version of PHPUnit and call the parent method.
|
@webimpress Please look at the travis build history and the jobs run for this PR. For the PHP 5/PHPUnit 4 combination, the memory consumption is a full 5x, and for the PHP 7.3/PHPUnit 7 combination, a full 3x. I'm not sure if it's a change in the build system in the past month, or if this patch introduces the slow down, but it either needs to be addressed or explained before we can merge. |
|
@weierophinney There was a bug in my implementation. Instead of using Still failing with latest dependencies on PHP 7.2 and 7.3. I'm looking on it. |
|
@webimpress looks like ready to deploy, right? |
|
@snapshotpl Yes, just someone from maintainers need to find time to release it. I've already pinged @weierophinney |
No description provided.