This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Update to allow usage of zend-code v3 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require PHP 5.6+ - Use PHPUnit 4.8+ - Use zend-code 2.* or 3.* - Replace php-cs-fixer with phpcs
- Lots of underscore-prefixed protected members. - Test files that contained multiple classes and/or functions; split these out. - Wrapped long lines.
- use composer autoloading instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reflection subcomponent of zend-code in v3 has no API changes that affect zend-server, and can be safely consumed by the component.
This patch updates the dependencies to allow zend-code v2 or v3 versions, and implements the lowest/locked/latest strategy for running tests on Travis. Additoinally, it updates the minimum required PHP version to 5.6, the PHPUnit version to 4.8, swaps in phpcs instead of php-cs-fixer, and fixes a ton of CS issues in the component.