This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Forwards compatibility with zend-servicemanager v3 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated zend-stdlib to `^2.7 || ^3.0` - Updated zend-servicemanager to `^2.7.5 || ^3.0.3` - Updated to known-stable, forwards compatible dependencies where possible. - Removed zend-modulemanager (not used) - Setup test matrix to specify version of zend-servicemanager to use; each version is tested against each PHP version as well. For 3.0.3 tests, zend-mvc is removed.
- Updated all factory implementations to use the v2 variants, which inherit the v3 methods in v3. - Added implementations for v2-specific factory methods. - Updated test codebase to use zend-servicemanager mutation methods instead of `configure()`. - Simplified test setup; application bootstrapping was unnecessary, and was simpler to achieve via straight SM configuration.
|
Marked as WIP, as realized the aliases and factory names listed in |
Re-enabled the `HelperConfig` tests, refactored to approximate the zend-mvc workflow, and watched the bugs start appearing. In the end, this became a substantial refactor: - This adds a factory for `Zend\View\Helper\Navigation`, to ensure it gets injected with the application-level service locator. - It also adds a delegator factory for the navigation view helper that ensures that the `HelperConfig` is used to configure the plugin manager composed in the navigation helper. This ensures that any `navigation_helpers` configuration is used, allowing developers to override or add to the navigation helpers. - The `HelperConfig` was also updated to ensure it works in both v2 and v3 of the service manager, and registers invokables as a combination of `InvokableFactory` mappings and aliases (if the service name and class differ). Essentially, I'm not sure how the `navigation_helpers` configuration *ever* worked, even in versions prior to the migration. It works now.
|
No longer a WIP; all tested and working now! |
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reverts some of the changes from #5 in favor of making the component forwards compatible with v3. Specifically:
^2.7 || ^3.0^2.7.5 || ^3.0.3ServiceFactorysignificantly, and reverts v3-specific zend-servicemanager setup to use setup compatible with both versions.Additionally, this patch updates the
Zend\Navigation\View\HelperConfigclass to ensure it works correctly against both v2 and v3 releases of zend-servicemanager. In particular, it adds testing to the class, which uncovered an interesting situation: the documentednavigation_helpersconfiguration previously did not work! With this patch, it now works correctly, regardless of version.