This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Treat quote as value if already in quote using another delimiter #226
Open
silvadiego
wants to merge
8
commits into
zendframework:master
Choose a base branch
from
silvadiego:222-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
407a06d
Treat quote as value if already in quote using another delimiter
silvadiego 1ca467c
CHANGELOG.md updated
silvadiego 376a5dc
Update Copyright year from 2018 to 2019
silvadiego 75d03e9
add test for #147 regression
glensc 82290a6
Removed ListParser tests file and cherry picked tests from pr 224
silvadiego 830696f
Fix cs
silvadiego ac9637e
Update CHANGELOG.md
silvadiego 2f644a9
Update CHANGELOG.md
silvadiego File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
/** | ||
* @see https://github.com/zendframework/zend-mail for the canonical source repository | ||
* @copyright Copyright (c) 2005-2018 Zend Technologies USA Inc. (https://www.zend.com) | ||
* @license https://github.com/zendframework/zend-mail/blob/master/LICENSE.md New BSD License | ||
*/ | ||
|
||
namespace ZendTest\Mail\Header; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Zend\Mail\Header\ListParser; | ||
|
||
/** | ||
* @covers Zend\Mail\Header\ListParser<extended> | ||
*/ | ||
class ListParserTest extends TestCase | ||
{ | ||
public function testParseIgnoreQuoteDelimiterIfAlreadyInQuote() | ||
{ | ||
$parsed = ListParser::parse('"john\'doe" <john@doe.com>,jane <jane@doe.com>'); | ||
$this->assertEquals($parsed, [ | ||
silvadiego marked this conversation as resolved.
Show resolved
Hide resolved
|
||
'"john\'doe" <john@doe.com>', | ||
'jane <jane@doe.com>' | ||
]); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2019 perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i will do that when i get home.