Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Fix regression introduced in 2.9.0 when overriding FileUpload default validator #175

Merged

Conversation

Slamdunk
Copy link
Contributor

#172 introduced a BC Break: till release-2.8.3 the default validator was set as alias 'fileuploadfile'. In a functional test environment it must be overridden, and thus until version 3 the alias used must be kept 'fileuploadfile'.

$chain->prependByName('fileuploadfile', [], true);
$this->autoPrependUploadValidator = false;

Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weierophinney weierophinney merged commit ff6d38d into zendframework:master Jan 7, 2019
weierophinney added a commit that referenced this pull request Jan 7, 2019
Fix regression introduced in 2.9.0 when overriding FileUpload default validator
weierophinney added a commit that referenced this pull request Jan 7, 2019
weierophinney added a commit that referenced this pull request Jan 7, 2019
weierophinney added a commit that referenced this pull request Jan 7, 2019
Forward port #175

Conflicts:
	CHANGELOG.md
@weierophinney
Copy link
Member

Thanks, @Slamdunk!

@Slamdunk Slamdunk deleted the bugfix/bc_break_validator_name branch January 8, 2019 04:40
@froschdesign froschdesign added this to the 2.9.1 milestone Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants