This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix #114 - validate collection #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
changed the title
weierophinney
added a commit
that referenced
this pull request
Aug 18, 2016
Fix #114 - validate collection
weierophinney
added a commit
that referenced
this pull request
Aug 18, 2016
weierophinney
added a commit
that referenced
this pull request
Aug 18, 2016
Forward port #118 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only test implemented as reported in #114.
I had a look on it and it seems to be a quite complex...
Edited:
errorMessageis now cleared (tonull) before validation the Input only when it is anarray.Why? The setter method
setErrorMessageaccept any type, but there is casting to(string).Method
prepareRequiredValidationFailureMessagecalled inisValidsets errorMessage to an array, and in this case we have to clear it before each validation.Probably it needs more refactor in future. Because current complexity of these validation there is terrible!