Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add StringPrefix filter with tests #69

Merged
merged 8 commits into from
Dec 12, 2018

Conversation

thexpand
Copy link
Contributor

#28

Copy link

@waltertamboer waltertamboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the way of caling the assert methods, it all looks good to me.

test/StringPrefixTest.php Show resolved Hide resolved
src/StringPrefix.php Outdated Show resolved Hide resolved
src/StringPrefix.php Outdated Show resolved Hide resolved
src/StringSuffix.php Outdated Show resolved Hide resolved
src/StringSuffix.php Outdated Show resolved Hide resolved
src/StringSuffix.php Outdated Show resolved Hide resolved
src/StringPrefix.php Outdated Show resolved Hide resolved
test/StringPrefixTest.php Outdated Show resolved Hide resolved
test/StringSuffixTest.php Outdated Show resolved Hide resolved
test/StringSuffixTest.php Outdated Show resolved Hide resolved
test/StringPrefixTest.php Outdated Show resolved Hide resolved
@thexpand thexpand changed the base branch from master to develop September 5, 2018 12:35
@weierophinney weierophinney added this to the 2.9.0 milestone Dec 12, 2018
weierophinney added a commit that referenced this pull request Dec 12, 2018
Add StringPrefix filter with tests
weierophinney added a commit that referenced this pull request Dec 12, 2018
- Modifies `$options` declaration to use `array<string, string|null>`
  for the type.
- No parens needed around ternary statements as argument values.
- Add space after casting operators.
weierophinney added a commit that referenced this pull request Dec 12, 2018
- Add names for each item in data providers.
- Import all classes used.
weierophinney added a commit that referenced this pull request Dec 12, 2018
@weierophinney weierophinney merged commit 24c0be4 into zendframework:develop Dec 12, 2018
weierophinney added a commit that referenced this pull request Dec 12, 2018
@weierophinney
Copy link
Member

Thanks, @thexpand! I have added documentation and merged for release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants