This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Prepare for zend-servicemanager/zend-stdlib v3 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `composer.json`: - Use v2 or v3 versions of stdlib, servicemanager. - Use latest versions of components that are forwards compatible. Updated `.travis.yml`: - added test jobs to test zend-servicemanager v2 usage separately from v3. - remove zend-validator and zend-progressbar when running against zend-servicemanager v3. Test updates: - skip tests related to validation when validator interface is missing. - skip tests related to progress bars when progress bar adapter is missing.
- Due to type checking in v2 vs v3 of zend-servicemanager, and the fact that zend-validator has not yet been updated, we need to check which version of zend-servicemanager we're running against before lazy-instantiating the validator plugin manager. - zend-filter is already updated, so we can use the v3 paradigm when lazy-instantiating the filter plugin manager. - skip the HTTP-adapter tests, as that adapter *requires* the validator plugin manager (it auto-injects the Upload validator during instantiation). - update the tests for filters as they use namespace separators in non-FQCN filter names.
|
👍 |
- Updated zend-validator dependency to `^2.6`, bringing in forwards-compat changes. - Removed code that was skipping zend-validator tests. - Moved aliases definitions in `ValidatorPluginManager` implementation to an alternate property, and defined a constructor that merges them with the parent `$aliases` prior to invoking the parent constructor. - Fixed an issue with filter resolution (added more aliases).
weierophinney
added a commit
that referenced
this pull request
Feb 17, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prepares zend-file for the v3 releases of zend-servicemanager and zend-stdlib.
I'm marking it as a work-in-progress, as I'm unsure it should be completed before zend-validator is completed.Currently, it does the following:
composer.jsonto use either the v2 or v3 versions of zend-stdlib and zend-servicemanager.composer.jsonto use forwards-compatible versions of components that rely on zend-servicemanager, if such versions exist..travis.ymlto do two jobs per PHP version, one against zend-servicemanager v3, the other against v2..travis.ymlto removezend-validator andzend-progressbar from the dev requirements when running against zend-servicemanager v3.Unfortunately,Zend\File\Transfer\Adapter\AbstractAdaptercurrently composes both filter and validator plugin managers, and its primary duty is to perform upload validation. TheAbstractTestis able to skip tests that interact with the validator plugin manager, but theHttpTestcannot, as the HTTP adapter sets an initialUploadvalidator during instantiation. Since this is so fundamental, my gut feeling is to wait for zend-validator to be complete before we consider this for merge.Update: this patch has been updated to pin against zend-validator
^2.6, which brings in the forwards-compatibility changes, allowing me to test all functionality except for one or two progress bar items. As such, it's ready.