This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Actually use result of array_unique #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug may have been harmless, the resulting regex would have been equivalent. Add simple test that parsing options with duplicates continues to succeed. (I didn't see any other tests of duplicates) Fixes zendframework#43
weierophinney
added a commit
that referenced
this pull request
Feb 4, 2019
Actually use result of array_unique
weierophinney
added a commit
that referenced
this pull request
Feb 4, 2019
|
Thanks, @TysonAndre; merged to develop for release with 2.8.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug may have been harmless, the resulting regex built would have been
longer but functionally equivalent.
Add simple test that parsing options with duplicates
continues to succeed. (I didn't see any other tests of duplicates)
Fixes #43
Provide a narrative description of what you are trying to accomplish:
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.