This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Use correct class names in the ClassGenerator implements and extend. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extends section of a class.
veewee
force-pushed
the
feature/valid-extends-and-implements-classnames
branch
from
77d26f3 to
4a6f4ab
Compare
weierophinney
added a commit
that referenced
this pull request
Jun 27, 2016
…ts-classnames Use correct class names in the ClassGenerator implements and extend.
weierophinney
added a commit
that referenced
this pull request
Jun 27, 2016
|
Thanks, @veewee ! |
kamilZ
added a commit
to kamilZ/zend-code
that referenced
this pull request
Jun 28, 2016
Error: symfony/symfony#9815 Tag: v3.0.3 PHP: 7.0.4 This should solve the issue with PR zendframework#69 @veewee check this out, please. I don't know if the ternary condition will be necessary. I put it anyway for compatibility with lower php version.
|
This is broken in case the class names used in |
|
That is indeed a case I did not know about and therefor did not cover. You might just want to use |
|
or just |
|
no, I don't think about other cases |
Ocramius
added a commit
to Ocramius/ProxyManager
that referenced
this pull request
Jul 1, 2016
Ocramius
added a commit
to Ocramius/ProxyManager
that referenced
this pull request
Jul 1, 2016
basz
added a commit
to basz/zend-code
that referenced
this pull request
Sep 28, 2016
* 'master' of https://github.com/zendframework/zend-code: (39 commits) Fix Travis code convention Fix Travis code convention Fix Travis code convention Fix Travis code convention 1. Fix ClassScanner::getInterfaces() which don't work with Interface. 2. add TestCase ClassScannerTest::testGetInterfacesFromInterface(). Remove fast_finish flag Bumped to next dev version (3.0.5) Added CHANGELOG for zendframework#75 Separated new tests to separate methods testCorrectExtendNamesFromGlobalNamespace add tests Added CHANGELOG for zendframework#59 Update ClassGenerator.php fast fix Bumped to next dev version (3.0.4) Set date for 3.0.3 Added CHANGELOG for zendframework#72 Added CHANGELOG for zendframework#69 Added CHANGELOG for zendframework#61 Provide a fix for issue zendframework#70 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #64. It will try to look for the classnames in the use statements and will validate if the classes live in the same namespace as the class that is being generated.
If this is the case, the short classname is being used instead of the full classname.
If this is not the case, the backslash is added to make sure that the classes can be loaded by PHP.