completes hasSomething & removeSomething methods on the Classgenerator

[basz]

This PR introduces removeSomething and hasSomething methods to the ClassGenerator and it's helpers classes.

[basz]

Any chance this will get merged?

[Ocramius]

@basz just checked this again: question, are remove* methods globally common among all of the generator classes? I don't want to introduce more inconsistencies in this already fairly riddled codebase.

[basz]

I added it to complement removeMethod (same class).

Whether it is consistently a common thing,.. it doesn't seem to be - but I do see some remove references.

[Ocramius]

@basz can you complete the API for the remove* methods on the generators then?

[basz]

@Ocramius I just added some remove* and has* methods for simple cases

see also #33

remaining methods proxy to TraitUsageGenerator

see

[Ocramius]

This is a BC break

[basz]

I am done with this PR, review (please)

the ones still missing are removeTraitAlias & hasTraitAlias, but...

[samsonasik]

need rebase

[Ocramius]

if empty() is used to compare against null, then use null !== $this->extendedClass instead, as an empty string would pass this check (and would be invalid)

[basz]

if (!empty($this->extendedClass)) {
    $output .= ' extends ' . $this->extendedClass;
}

both null and "" should be false.

This was present. I just reused...

[basz]

@Ocramius what's the plan for this?

You mentioned refactoring TraitUsageGenerator::$uses which now is an strongly typed representation

Can we merge this in 3 (ugly but it works) and refactor that for 4.0?

[Ocramius]

Totally missed this PR, sorry @basz. Merging into develop now.

[Ocramius]

Merged into develop via 3a9ec93

Thanks @basz!