Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix: replace curly offset access brace with square brackets #171

Merged
merged 1 commit into from
Aug 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NameInformation.php
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ public function getUses()
*/
public function resolveName($name)
{
if ($this->namespace && ! $this->uses && strlen($name) > 0 && $name{0} != '\\') {
if ($this->namespace && ! $this->uses && strlen($name) > 0 && $name[0] != '\\') {
return $this->namespace . '\\' . $name;
}

if (! $this->uses || strlen($name) <= 0 || $name{0} == '\\') {
if (! $this->uses || strlen($name) <= 0 || $name[0] == '\\') {
return ltrim($name, '\\');
}

Expand Down
4 changes: 2 additions & 2 deletions src/Scanner/Util.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ public static function resolveImports(&$value, $key = null, stdClass $data = nul
));
}

if ($data->namespace && ! $data->uses && strlen($value) > 0 && $value{0} != '\\') {
if ($data->namespace && ! $data->uses && strlen($value) > 0 && $value[0] != '\\') {
$value = $data->namespace . '\\' . $value;

return;
}

if (! $data->uses || strlen($value) <= 0 || $value{0} == '\\') {
if (! $data->uses || strlen($value) <= 0 || $value[0] == '\\') {
$value = ltrim($value, '\\');

return;
Expand Down
2 changes: 1 addition & 1 deletion test/Generator/FileGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public function testFileLineEndingsAreAlwaysLineFeed()

$targetLength = strlen('require_once \'SampleClass.php\';');
self::assertEquals($targetLength, strlen($lines[2]));
self::assertEquals(';', $lines[2]{$targetLength - 1});
self::assertEquals(';', $lines[2][$targetLength - 1]);
}

/**
Expand Down