Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): align success, warning, and danger border color variables with design #1936

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Sep 30, 2024

Description

Adjusts border.success, border.warning, and border.danger from shade 800 to 900 to align with variables in Figma. Verified that Alert is the only component impacted by the change.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel requested a review from a team as a code owner September 30, 2024 18:27
@jzempel jzempel merged commit 8f5f029 into main Sep 30, 2024
8 checks passed
@jzempel jzempel deleted the jzempel/alert-border branch September 30, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants