Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: restore Coveralls PR comments #1934

Merged
merged 4 commits into from
Sep 30, 2024
Merged

ci: restore Coveralls PR comments #1934

merged 4 commits into from
Sep 30, 2024

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Sep 27, 2024

Description

Uses coverallsapp/github-action to restore Coveralls PR comments. Speeds up test job. 🚄

Details

  • Uses and pins coverallsapp/github-action to commit SHA associated with latest v2.3.0 (see best-practices)
  • Removes coveralls npm package
  • Restores missing PR comments
  • Speeds up test job by running test concurrently (removed --runInBand):

Screenshot 2024-09-27 at 11 49 13 AM

Testing

@coveralls
Copy link

coveralls commented Sep 27, 2024

Coverage Status

coverage: 95.904%. remained the same
when pulling d887ff4 on ze-flo/coverall-fix
into f4b6fd4 on main.

- run: npm exec -- coveralls < .cache/coverage/lcov.info
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
- uses: coverallsapp/github-action@643bc377ffa44ace6394b2b5d0d3950076de9f63 # v2.3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points to 2.3.0 tag.

coverallsapp/github-action@643bc37

Screenshot 2024-09-27 at 11 57 39 AM

@ze-flo ze-flo marked this pull request as ready for review September 27, 2024 21:58
@ze-flo ze-flo requested a review from a team as a code owner September 27, 2024 21:58
@ze-flo ze-flo merged commit 8c383a0 into main Sep 30, 2024
8 checks passed
@ze-flo ze-flo deleted the ze-flo/coverall-fix branch September 30, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants