Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add removal of theme default prop ADR #1914

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Sep 6, 2024

Description

Adds the "Removal of theme default prop" ADR. See reference PR for context: #1905

@ze-flo ze-flo requested a review from a team as a code owner September 6, 2024 21:14
@ze-flo ze-flo changed the title docs: add removal of theme default prop ADR Docs: add removal of theme default prop ADR Sep 6, 2024
@ze-flo ze-flo changed the title Docs: add removal of theme default prop ADR docs: add removal of theme default prop ADR Sep 6, 2024
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Co-authored-by: George Treviranus <3946669+geotrev@users.noreply.github.com>
@ze-flo ze-flo requested a review from geotrev September 9, 2024 22:09
@ze-flo ze-flo merged commit 401b82f into main Sep 10, 2024
7 checks passed
@ze-flo ze-flo deleted the ze-flo/default-prop-removal-adr branch September 10, 2024 17:46
@ze-flo ze-flo mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants