Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): add border-color transition for smoother animation #1904

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Aug 23, 2024

Description

Improves Tab border animation when toggling between light / dark mode.

See zendeskgarden/website#626 (comment).

A more comprehensive PR to cover other color transitions will follow.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳

@ze-flo ze-flo merged commit fe2bd93 into main Aug 23, 2024
8 checks passed
@ze-flo ze-flo deleted the ze-flo/tab-border-transition branch August 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants