feat(buttons): underline Anchor by default
#1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
reviewed
Jul 24, 2024
Comment on lines
+55
to
+60
| - `Anchor`: renders with an underline for improved accessibility. The same | ||
| treatment applies to `<Button isLink>`. The default can be removed with | ||
| `<Anchor isUnderlined={false}>` for word-wrapped or redundant UI where the | ||
| underline is considered to be a visual distraction. While technically not a | ||
| breaking change, the migration guide highlights this change for upgrade cases | ||
| that may render unexpected styling. |
There was a problem hiding this comment.
Should we mention that <Button isLink /> will always render with an underline?
There was a problem hiding this comment.
My instinct is not to highlight that aspect too hard, and see if consumers need the non-default styling over buttons. If so, we can add a isLinkUnderlined (or similar) prop.
There was a problem hiding this comment.
I suspect as long as the designs match this new default, we won't get too much humbuzz :D cc: @lucijanblagonic
ze-flo
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The same default styling applies to
<Button isLink>. Due to expected usage, the link-styledButtondoes not offer a capability to remove the underline. Note that existing hover/focus/active styling remains unchanged.Checklist
npm start)renders as expected with reversed (RTL) direction?bedrock)tested in Chrome, Firefox, Safari, and Edge