Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: renames and prunes type/constant exports from packages #1725

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

geotrev
Copy link
Contributor

@geotrev geotrev commented Feb 28, 2024

Description

  • Refines type naming to match Garden typescript style guidelines.
  • Removes deprecated types and interfaces
  • Updates migration.md with changes

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@geotrev geotrev self-assigned this Feb 28, 2024
@geotrev geotrev requested a review from a team as a code owner February 28, 2024 16:48
@coveralls
Copy link

Coverage Status

coverage: 96.012%. remained the same
when pulling 87c884a on george/types
into 421960b on next.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@geotrev geotrev merged commit 6844b7a into next Feb 28, 2024
5 checks passed
@geotrev geotrev deleted the george/types branch February 28, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants