Support batch update resources #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure specs will pass after #345. |
otoyo
commented
Sep 9, 2017
lib/zendesk_api/actions.rb
Outdated
| # @param [Hash] attributes The attributes to update resources with | ||
| # @return [JobStatus] the {JobStatus} instance for this destroy job | ||
| def update_many!(client, ids, attributes) | ||
| def update_many!(client, ids_or_attributes_array, attributes = {}) |
There was a problem hiding this comment.
ids_or_attributes_array naming looks not good to me...
There was a problem hiding this comment.
I'd leave off the _array ... and make attributes=nil to mke the check simpler
There was a problem hiding this comment.
Sounds good to me but L283 might need conditions.
|
@grosser Would you be able to review this also, please? |
grosser
approved these changes
Sep 9, 2017
|
let me know what you think of my suggestions ... looks good to merge either way |
|
I've left |
grosser
reviewed
Sep 9, 2017
spec/core/bulk_actions_spec.rb
Outdated
| @@ -47,22 +47,44 @@ | |||
| subject { ZendeskAPI::BulkTestResource } | |||
|
|
|||
| context "update_many!" do | |||
| let(:attributes) { { :name => 'A', :age => 25 } } | |||
| context "arity: 3" do | |||
grosser
reviewed
Sep 9, 2017
spec/core/bulk_actions_spec.rb
Outdated
| it 'returns a JobStatus' do | ||
| expect(@response).to be_instance_of(ZendeskAPI::JobStatus) | ||
| expect(@response.id).to eq('ghi') | ||
| context "arity: 2" do |
There was a problem hiding this comment.
updating with multiple attribute hashes
|
1.15.0 🎉 |
|
Thank you for your review! |
|
thx for some great PRs :)
…On Fri, Sep 8, 2017 at 8:45 PM, Hiroki Toyokawa ***@***.***> wrote:
Thank you for your review!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#344 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ1V3p9U4nayWQZ2Vhbtd7Gu5XzoQks5sggnJgaJpZM4PJ9E3>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support batch update resources.
e.g. https://developer.zendesk.com/rest_api/docs/core/tickets#batch-updates