Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RED-2643] Fix issue when iterating over help center categories #548

Conversation

token-cjg
Copy link
Contributor

In short

This should fix this issue: #543

It achieves this by providing a plural name to all relevant help center objects.

References

Risks

  • Low: Might break the help center part of API interactivity for this library.

@token-cjg token-cjg marked this pull request as ready for review January 15, 2025 22:32
@token-cjg token-cjg requested a review from a team as a code owner January 15, 2025 22:32
Copy link
Contributor

@Zendesk-NathanBellette Zendesk-NathanBellette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zendesk-NathanBellette Zendesk-NathanBellette merged commit d06ad95 into master Jan 15, 2025
3 checks passed
token-cjg pushed a commit that referenced this pull request Jan 15, 2025
…-iterating-over-help-center-categories

[RED-2643] Fix issue when iterating over help center categories
token-cjg added a commit that referenced this pull request Jan 15, 2025
…-iterating-over-help-center-categories (#550)

[RED-2643] Fix issue when iterating over help center categories

Co-authored-by: Zendesk-NathanBellette <90431205+Zendesk-NathanBellette@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants