Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump supported php version to 8.2 #546

Merged
merged 18 commits into from
Dec 18, 2024
Merged

Bump supported php version to 8.2 #546

merged 18 commits into from
Dec 18, 2024

Conversation

token-cjg
Copy link
Contributor

@token-cjg token-cjg commented Dec 10, 2024 •
edited
Loading

Synopsis

This change bumps the minimum supported PHP version of this package to PHP 8.2.

In more detail

According to PHP supported versions:

  • 8.0 and lower are EOL
  • 8.1 is receiving security fixes only
  • 8.2 is subject to active support, and in a handful of days is slated to mature to the "security fixes only" stage.

So there is an argument to bump to 8.1 at the very least.

Screenshot 2024-12-18 at 11 16 23 AM

Decision

I've decided to opt for 8.2 as

  • said version of the language has been around for more than 2 years now, so I would view it as being moderately battle-tested.
  • a number of members of the community have recently expressed interest in better support for PHP 8.2
  • PHP 8.2 is imminently (in a matter of days) about to mature to the "security fixes only" stage, which means that there should be no more significant changes to said branch of the language going forward apart from said security patches

References

@token-cjg token-cjg force-pushed the cgoddard/bump-version-symphony-dep-injection branch from 1e0cf7b to acae0c5 Compare December 10, 2024 05:05
@token-cjg
Ignore phpunit output file
fd4354d
@token-cjg
Add simple composer scripts for easier testing
6152089
@token-cjg
Resolve static function errors
ba0f9e7
@token-cjg
Handle phpunit test method + annotation deprecations
d191fc5
@token-cjg
Fix: Adjust names of test objects to objects under test
391474a 
This will deal with a couple of warning messages that occur during test run
@token-cjg
Exclude basic test (abstract class) from test suites to avoid warn
8a585eb 
So that we don't get a phpunit warning message, let's exclude these abstract
classes from each respective test suite, as they were not being run anyway.
@token-cjg token-cjg marked this pull request as ready for review December 17, 2024 23:52
@token-cjg token-cjg requested a review from a team as a code owner December 17, 2024 23:52
@token-cjg
Fix deprecated annotations by asserting in test
d253324
@token-cjg
Fix broken test by searching on email rather than name
55be3ed
@token-cjg
Bump to php 8.2.27
128f867 
- PHP 8.2.27 was released yesterday [1] so let's ensure that we get the latest
  and greatest version of this branch at least in terms of our asdf config

[1] https://www.linuxcompatible.org/story/php-8227-released/
@token-cjg token-cjg merged commit d81417a into master Dec 18, 2024
3 checks passed
@token-cjg token-cjg deleted the cgoddard/bump-version-symphony-dep-injection branch December 18, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@token-cjg