Pagination Iterator with params #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecoologic
commented
Oct 31, 2023
| $strategy = new $strategyClass($this, $this->resourcesKey(), AbstractStrategy::DEFAULT_PAGE_SIZE); | ||
| return new PaginationIterator($strategy); | ||
| $strategy = new $strategyClass($this->resourcesKey(), AbstractStrategy::DEFAULT_PAGE_SIZE); | ||
| return new PaginationIterator($this, $strategy); |
There was a problem hiding this comment.
instead of passing $this for the strategy to run findAll() duplicated in every strategy inside getPage(), extract it in the Iterator as a function for the strategy to run (see below).
ecoologic
commented
Oct 31, 2023
| $this->page = array_merge($this->page, $this->strategy->getPage()); | ||
| $pageFn = function ($params = []) { | ||
| return $this->clientList->findAll($params); | ||
| }; |
There was a problem hiding this comment.
This is more DRY, so adding params and later maybe making the method dynamic (findAll, find, active, etc) in one place only instead of each Strategy.
ecoologic
force-pushed
the
RED-2001-params
branch
from
d55dcf3 to
13bcecd
Compare
ecoologic
commented
Nov 1, 2023
| * @var string The response key where the data is returned | ||
| */ | ||
| protected $resourcesKey; | ||
| protected $pageSize; | ||
|
|
||
| public function __construct($clientList, $resourcesKey, $pageSize = self::DEFAULT_PAGE_SIZE) | ||
| public function __construct($resourcesKey, $pageSize = self::DEFAULT_PAGE_SIZE) |
There was a problem hiding this comment.
Now the Strategies are more cohesive.
ecoologic
force-pushed
the
RED-2001-params
branch
from
13bcecd to
32ae8bf
Compare
fbvilela
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to call the iterator with params as such:
I will update the README in the next card, as I'll probably start the upgrade guide then too.