CBP tickets #511
Merged
CBP tickets #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecoologic
force-pushed
the
RED-1952-cbp-tickets
branch
from
d3091ee to
561e493
Compare
ecoologic
force-pushed
the
RED-1952-cbp-tickets
branch
from
561e493 to
f7ba5cc
Compare
ecoologic
force-pushed
the
RED-1952-cbp-tickets
branch
3 times, most recently
from
34a073e to
e913988
Compare
ecoologic
force-pushed
the
RED-1952-cbp-tickets
branch
from
e913988 to
b3b232e
Compare
ecoologic
commented
Oct 18, 2023
| public function valid() | ||
| { | ||
| if (!isset($this->tickets[$this->position]) && (!$this->started || $this->afterCursor)) { | ||
| $this->getPage(); |
There was a problem hiding this comment.
note we only fetch the next page if we're done with the current one. we don't want to fetch all pages and then do all the processing. This is also in the readme.
ecoologic
commented
Oct 18, 2023
| */ | ||
| public function current() | ||
| { | ||
| if (!isset($this->tickets[$this->position]) && (!$this->started || $this->afterCursor)) { |
There was a problem hiding this comment.
I just noted this can be abstracted. I'll do that in my next PR.
ecoologic
commented
Oct 18, 2023
| /** | ||
| * @return Ticket The current ticket, possibly fetching a new page. | ||
| */ | ||
| public function current() |
There was a problem hiding this comment.
this, valid, key and other methods are part of the PHP Iterator pattern.
fbvilela
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing CBP Iterator for Tickets.
This will be generalized in coming PR.
Usage: See README and tests, but basically:
Note that this PR doesn't address sorting and other params yet. It will be added in a different iteration.