Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translations as a resource name and be able to specify the apiBaseUrl #483

Merged

Conversation

willshen8
Copy link
Contributor

@willshen8 willshen8 commented Feb 1, 2022

Goal of this PR:

laravel-i18n-command is a translation library that uses this library to pull down translations files in json format. As we move the endpoint
from: https://support.zendesk.com/api/v2/locales/en.json?include=translations&packages=slack-auth-service
to: https://static.zdassets.com/translations/slack-auth-service/manifest.json

This is a need to specify the domain and resources to be other than api/v2.

We want to be able to do this:

$this->client->translations()->find();

to return back the contents of the manifest file for a particular service such as slack-auth-service.

…h to accept a different value than the hard-coded one
@willshen8 willshen8 added the wip label Feb 1, 2022
@willshen8 willshen8 changed the title added translation as a resource for httpClient and updated apiBasePat… Add Translations as a resource name and be able to specify the apiBaseUrl Feb 1, 2022
@willshen8 willshen8 removed the wip label Feb 1, 2022
@willshen8 willshen8 merged commit 0f3bf99 into master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants