Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guzzlehttp/psr7 2.0 #480

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Allow guzzlehttp/psr7 2.0 #480

merged 1 commit into from
Jun 20, 2022

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Jan 11, 2022

With #469 being merged, this package now supports 1.7+ and 2.0

With zendesk#469 being merged, this package now supports 1.7+ and 2.0
@ianwelsh
Copy link

ianwelsh commented Feb 2, 2022

We are unable to use the zendesk client without this. Any update on merging it?

@deluxetom
Copy link

+1 to merge this PR as guzzlehttp/psr 2.0 is supported

@gjuric
Copy link

gjuric commented Mar 11, 2022

Another +1

@PululuK
Copy link

PululuK commented Mar 14, 2022

+1

@baiiko
Copy link

baiiko commented Mar 16, 2022

Hey @7ail

You can merge this request and up a new version ? :)

BR,

Edit: A teammate fork this repo with this fix, and it's work please ... 🙏

@gjuric gjuric mentioned this pull request Mar 28, 2022
@cuongthetran
Copy link

+1

@ethanbeyer
Copy link

Dear Zendesk, please merge this.

@oojacoboo
Copy link

It's well over 3 months since this very simple PR has been submitted. There is no excuse for this to not have already been merged.

@sbacelic
Copy link

+1

@PululuK
Copy link

PululuK commented Apr 29, 2022

Hello Guys,

I just fork the project see https://github.com/PululuK/zendesk_api_client_php
I can add new maintainers if you are motivated to contribute.
I will release soon :)

Thanks

@gjuric
Copy link

gjuric commented May 2, 2022

Thank you @PululuK but I expect from the company to not ignore their official client.

@wouterj
Copy link
Contributor Author

wouterj commented May 24, 2022

@willshen8 @yoshdog @manted what can I do to help you merge this PR?
At the moment, this PR is creating noise in both your and my GitHub inbox. At the same time, it is blocking all of Zendesk's users to upgrade their stack.

@gjuric
Copy link

gjuric commented May 24, 2022

Not sure what needs to happen to get this thing merged. This PR exists since January, I've even opened an issue #487 almost two months ago and there was no communication from the company.

In the meantime I've contacted Zendesk support since we are paying for the platform after all but they were unresponsive.

Right now, I've just checked Zendesk documentation https://developer.zendesk.com/documentation/ticketing/api-clients/php/ and it looks like this client is not officially supported by Zendesk, it would be nice if they stated that in the Readme.

For those of you tired of waiting I propose that you either check @PululuK 's fork or check Packagist docs for Loading a package from a VCS repository.

@jasonlav
Copy link

jasonlav commented Jun 8, 2022

This fix is necessary to run the Laravel 8, which depends on Monolog and requires PS7 ^2.0.

@simonmaass
Copy link

@7ail @willshen8 @yoshdog any help?

@manted manted merged commit d1da1a7 into zendesk:master Jun 20, 2022
@wouterj wouterj deleted the patch-1 branch June 20, 2022 07:13
@PululuK
Copy link

PululuK commented Jun 20, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.