Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Http.php #472

Closed
wants to merge 1 commit into from
Closed

Update Http.php #472

wants to merge 1 commit into from

Conversation

RobinBoersma
Copy link

@RobinBoersma RobinBoersma commented Jul 27, 2021

Deprecated: stream_for will be removed in guzzlehttp/psr7:2.0. Use Utils::streamFor instead.
Fixes #470

Deprecated: stream_for will be removed in guzzlehttp/psr7:2.0. Use Utils::streamFor instead.
@Gramzivi
Copy link

Gramzivi commented Sep 1, 2021

There is a problem with this commit because it won't work in Guzzle versions from 6.0 to 7.1 as it is written in composer.json

@jmwebslave
Copy link

We too have run into this bug. While I agree it won't work in Guzzle 6.0-7.1 the problem is anyone pulling in the code now won't have it work. I'd suggest it's probably more critical to have it work for the current versions than it is for the old versions, since anyone running older versions won't have pulled this code anyway.

@Gramzivi
Copy link

Gramzivi commented Sep 6, 2021

I think maybe the safest solution, for now, is just to update the composer.json file according to working versions. If you have an existing project, a new composer install would mess your system. And tag new version with this update, to enable others to make difference between the old and new version of guzzle. But the problem is that Zendesk does not maintain this project anymore, so I don't know if anyone can merge updates.

@schonhoff
Copy link

I can't use Guzzle 1.x anymore because of other dependencies. Is there a solution without forking this package?

@ecoologic
Copy link
Contributor

This solution has already been implemented. Thank you for your contribution.

@ecoologic ecoologic closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to undefined function GuzzleHttp\Psr7\stream_for()
5 participants