Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zendesk Sell API and Contacts resource support #463

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Alex-Sh
Copy link
Contributor

@Alex-Sh Alex-Sh commented Jan 12, 2021

Added Sell API "Contacts" endpoint support
https://developers.getbase.com/docs/rest/reference/contacts

@Alex-Sh
Copy link
Contributor Author

Alex-Sh commented Jan 13, 2021

The only thing here is Zendesk Sell have different endpoint so HttpClient should be created like this:

$client = new HttpClient('', '', 'https', 'api.getbase.com');
$client->setAuth('oauth', ['token' => 'TOKEN']);

@Alex-Sh Alex-Sh mentioned this pull request Jan 13, 2021
@AxelDeneu
Copy link

Is it possible to merge this PR ? Pretty useful if you use Sell API.

@ecoologic
Copy link
Contributor

Hi,

thank you for your request,
are you still interested in a solution for this issue?

@ecoologic
Copy link
Contributor

Closing due to inactivity. Re-open if needed.

@ecoologic ecoologic closed this May 13, 2024
@AxelDeneu
Copy link

Sorry, I missed your comment. I'm still interested in a solution for this issue.

@ecoologic
Copy link
Contributor

Hi Alex, no worries. Thanks for your contribution.

@ecoologic ecoologic reopened this May 24, 2024
@ecoologic ecoologic requested a review from a team as a code owner May 24, 2024 04:15
@AxelDeneu
Copy link

Thank you too!
If needed, I can contribute on this PR, I don't know if @Alex-Sh is still interested into but I am. So if I can help in any kind, tell me.

@token-cjg token-cjg merged commit 18f3bcb into zendesk:master Sep 24, 2024
2 of 3 checks passed
@token-cjg
Copy link
Contributor

Thank you for your contribution @Alex-Sh, I have accepted your suggestion in this PR: #537.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants