Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HelpCenter Article creation #372

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

abackstrom
Copy link
Contributor

This patch adds support for Article creation via chaining, e.g.:

$article = $client->helpCenter->sections($sectionId)->articles()->create([
    'locale' => 'en-us',
    'title' => 'Smartest Fish in the World',
]);

The unit tests pass. I had some trouble running the "Live" tests against a Sandbox instance.

My team is relatively new to this code base, so I apologize in advance if any of this is off! Creation via chaining seemed to be the expected implementation.

@dpawluk
Copy link
Contributor

dpawluk commented Jan 25, 2018

Hi team, can we please review this PR and let @abackstrom know if it looks good or there are any other steps before we can approve? Also cc @yuri4zendesk

Copy link
Contributor

@samgavinio samgavinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @zendesk/mintegrations need another 👍 to merge.

@samgavinio samgavinio merged commit d641860 into zendesk:master Jan 26, 2018
@samgavinio samgavinio mentioned this pull request Jan 26, 2018
@abackstrom abackstrom deleted the helpcenter-article-creation branch January 26, 2018 20:30
lyrixx pushed a commit to lyrixx/zendesk_api_client_php that referenced this pull request Jun 24, 2019
…ation

Implement HelpCenter Article creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants